Consider reducing paragraph margin to 3px #17

Closed
opened 2026-05-09 22:52:28 +00:00 by rose · 1 comment
Contributor

The bottom paragraph currently has a margin of .4em 0 0, which cuts off the bottom pixel on my device.

How it looks for me:

image

Notice the underlines are cut off. Compare to this screenshot from Ari's device where the underlines are appropriately visible.

A margin of 2px looks better than 0.4em on my device:

image

(Omitting the empty row of pixels under the underline would be fine, though.)

If I change the margin to 0, I get a row of empty pixels at the top of the ad for some reason, which is undesirable:

image

I'm using Firefox 150.0.2 on Ubuntu 24.04. Browser tools tell me that the margin-top is computed to 3.6 pixels, so maybe yours rounds down to 3px while mine rounds up to 4px?

The bottom paragraph currently has a margin of `.4em 0 0`, which cuts off the bottom pixel on my device. How it looks for me: ![image](/attachments/de142785-6f48-4e57-9270-52fbaec4cf33) Notice the underlines are cut off. Compare to [this screenshot from Ari's device](https://git.ari.lt/ari.lt/arivertisements/attachments/e50929f6-aebb-4a4c-8939-62b76d37a73e) where the underlines are appropriately visible. A margin of 2px looks better than 0.4em on my device: ![image](/attachments/3397ac0f-cc83-423f-9742-f9bd2250f362) (Omitting the empty row of pixels *under* the underline would be fine, though.) If I change the margin to 0, I get a row of empty pixels at the top of the ad for some reason, which is undesirable: ![image](/attachments/c4cc1c3c-5490-47e6-afe2-be7b049fe264) I'm using Firefox 150.0.2 on Ubuntu 24.04. Browser tools tell me that the margin-top is computed to 3.6 pixels, so maybe yours rounds down to 3px while mine rounds up to 4px?
161 KiB
161 KiB
161 KiB
ari closed this issue 2026-05-09 23:03:37 +00:00
Owner

Thank you so much for your thorough report!

That's something I haven't noticed during my local testing (phone, PC, VM) OUTSIDE of one instance when loading the embed via old internet explorer, which I assumed was just an IE-ism. No-one's ever reported this until now so I thought I was in the clear.

The issue, in fact, seemed to not particularly be just the margin on its own, but rather the font-size in combination with relative em units, which I assumed to be consistent for monospace fonts. Guess not.

I have pushed a fix for this by changing to static px units instead of em - using relative units is kind of a filthy habit of mine.

image

After the fix, even old IE seems to be working now:

image

P.S. For back-end related issues the correct repository would be https://git.ari.lt/ari.lt/ad.ari.lt ;)

Thank you so much for your thorough report! That's something I haven't noticed during my local testing (phone, PC, VM) OUTSIDE of one instance when loading the embed via old internet explorer, which I assumed was just an IE-ism. No-one's ever reported this until now so I thought I was in the clear. The issue, in fact, seemed to not particularly be just the margin on its own, but rather the `font-size` in combination with relative `em` units, which I assumed to be consistent for `monospace` fonts. Guess not. I have pushed a fix for this by changing to static `px` units instead of `em` - using relative units is kind of a filthy habit of mine. ![image](/attachments/ab707ff2-c7b5-4fc8-bdbe-fb4664f57085) After the fix, even old IE seems to be working now: ![image](/attachments/f7c7bf3c-9f50-4dc7-bff9-34f34c4db5e0) P.S. For back-end related issues the correct repository would be https://git.ari.lt/ari.lt/ad.ari.lt ;)
410 KiB
505 KiB
Sign in to join this conversation.
No labels
image
No milestone
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ari.lt/arivertisements#17
No description provided.