ari/vessel
ari/vessel
1
2
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

CMake build system support. #2

Merged
ari merged 3 commits from :main into main 2025-05-25 15:52:18 +00:00
Conversation 2 Commits 3 Files changed 5 +175 -51
Gryb4s commented 2025-05-25 15:35:26 +00:00
Contributor
Copy link
No description provided.
Gryb4s added 1 commit 2025-05-25 15:35:27 +00:00
Gryb4s added 1 commit 2025-05-25 15:41:13 +00:00
ari requested changes 2025-05-25 15:47:45 +00:00
Dismissed
ari left a comment
Owner
Copy link

See my CR

See my CR
README.md Outdated
@ -122,0 +122,4 @@
### Compiling
- To compile vessel manually please execute following commands
ari commented 2025-05-25 15:47:15 +00:00
Owner
Copy link

this will be a code block, please remove the leading 4 spaces

this will be a code block, please remove the leading 4 spaces
Gryb4s marked this conversation as resolved
compile.sh
@ -0,0 +15,4 @@
for arg in "$@"
do
case "$arg" in
ari commented 2025-05-25 15:47:32 +00:00
Owner
Copy link

can you make the arguments lowercase maybe

can you make the arguments lowercase maybe
Gryb4s marked this conversation as resolved
Gryb4s added 1 commit 2025-05-25 15:50:07 +00:00
requested review from ari 2025-05-25 15:51:31 +00:00
ari approved these changes 2025-05-25 15:52:01 +00:00
ari left a comment
Owner
Copy link

LGTM

LGTM
ari merged commit 611cddb5be into main 2025-05-25 15:52:18 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
ari
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: ari/vessel#2
No description provided.
Delete branch ":main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?