muyrety/Smarter
1
1
Fork 1
Code Issues Pull requests Projects Releases 5 Packages Wiki Activity Actions

Security update __init__.py #1

Closed
pdavek wants to merge 1 commit from patch-1 into main
pull from: patch-1
merge into: muyrety:main
Conversation 2 Commits 1 Files changed 1 +9 -2
pdavek commented 2025-04-28 19:42:30 +00:00 (Migrated from github.com)
Copy link

Secret key was hardcoded to "dev". A proper secret key shall be added to .env to make it safe and publicly deployable. If it is not present it'll fallback to "dev" so it will work even if you don't do it

sqlite path also changed to make it more secure, database URL can be also added secretly.

Secret key was hardcoded to "dev". A proper secret key shall be added to .env to make it safe and publicly deployable. If it is not present it'll fallback to "dev" so it will work even if you don't do it sqlite path also changed to make it more secure, database URL can be also added secretly.
muyrety commented 2025-04-28 19:54:35 +00:00 (Migrated from github.com)
Copy link

Thank you for contributing. However, the default variables would be overwritten in production by the configuration loaded from config.py in the instance folder. This is recommended in the README.md. Although, a comment could be added in the code for more clarity. Same goes for the database.

Thank you for contributing. However, the default variables would be overwritten in production by the configuration loaded from config.py in the instance folder. This is recommended in the README.md. Although, a comment could be added in the code for more clarity. Same goes for the database.
pdavek commented 2025-04-28 20:25:07 +00:00 (Migrated from github.com)
Copy link

Oh I see, sorry for that.

Oh I see, sorry for that.
👍 1

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: muyrety/Smarter#1
No description provided.
Delete branch "patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?